Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-operator] Update helm chart to version 1.49.0 #510

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

cfis
Copy link
Contributor

@cfis cfis commented Oct 10, 2023

What this PR does

Bump jaeger operator image and helm chart versions to 1.49.0

Which issue this PR fixes

N/A

Checklist

  • [ x] DCO signed
  • [ x] Commits are GPG signed
  • [ x] Chart Version bumped
  • [ x] Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • [ x] README.md has been updated to match version/contain new values

@batazor
Copy link
Member

batazor commented Oct 11, 2023

@cfis can you sign the commit?

@cfis
Copy link
Contributor Author

cfis commented Oct 11, 2023

On my end it shows signed?

Commit 81780e2983522f0357ca29bd1110df5d91aaf062 (HEAD -> operator_v_1_49_0, origin/operator_v_1_49_0)
Author: Charlie Savage <charlie.savage@orbitalinsight.com>
Date:   Tue Oct 10 16:21:08 2023 -0700

    Update jaeger operator helm chart to 1.49.0
    
    Signed-off-by: Charlie Savage <charlie.savage@orbitalinsight.com>

However, I did sign it after the original commit when I realized I had to a couple minutes later and then did a git commit --amend --sign and then git commit push --force.

Maybe that didn't get picked up by the PR?

@cfis
Copy link
Contributor Author

cfis commented Oct 11, 2023

Seems like its signed in the PR?

image

@cfis cfis force-pushed the operator_v_1_49_0 branch 2 times, most recently from 0d3fb52 to 50a0aa3 Compare October 11, 2023 05:03
Signed-off-by: Charlie Savage <cfis@savagexi.com>
@cfis
Copy link
Contributor Author

cfis commented Oct 11, 2023

Ok, figured it out, sorry for my confusion. Commit is now verified.

@batazor
Copy link
Member

batazor commented Oct 11, 2023

@cfis thanks

@batazor batazor merged commit f78e187 into jaegertracing:main Oct 11, 2023
3 checks passed
@cfis cfis deleted the operator_v_1_49_0 branch October 11, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants