Add public method isFinished() on JaegerSpan (#634)

* Add public method isFinished() on JaegerSpan Signed-off-by: Doug Chimento <dchimento@gmail.com> * Adding sync block around isFinished for JaegerSpan Signed-off-by: Doug Chimento <dchimento@gmail.com>
jaegertracing · Aug 3, 2019 · f1a7ca9 · f1a7ca9
1 parent d773589
commit f1a7ca9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/jaeger-core/src/main/java/io/jaegertracing/internal/JaegerSpan.java b/jaeger-core/src/main/java/io/jaegertracing/internal/JaegerSpan.java
@@ -75,6 +75,12 @@ public long getStart() {
     return startTimeMicroseconds;
   }
 
+  public boolean isFinished() {
+    synchronized (this) {
+      return finished;
+    }
+  }
+
   public long getDuration() {
     synchronized (this) {
       return durationMicroseconds;

diff --git a/jaeger-core/src/test/java/io/jaegertracing/internal/JaegerSpanTest.java b/jaeger-core/src/test/java/io/jaegertracing/internal/JaegerSpanTest.java
@@ -158,6 +158,12 @@ public void testSetNumberTag() {
     assertEquals(expected, jaegerSpan.getTags().get(key));
   }
 
+  @Test
+  public void testFinished() {
+    jaegerSpan.finish();
+    assertTrue(jaegerSpan.isFinished());
+  }
+
   @Test
   public void testSetTag() {
     jaegerSpan.setTag(new StringTag("stringTag"), "stringTagValue")