Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Java 6 compatibility #129

Closed
felixbarny opened this issue Mar 5, 2017 · 2 comments · Fixed by #132
Closed

Java 6 compatibility #129

felixbarny opened this issue Mar 5, 2017 · 2 comments · Fixed by #132

Comments

@felixbarny
Copy link
Contributor

Hi,

it would be nice if Jaeger was Java 6 compatible as I want to use it for stagemonitor, which currently is Java 6 compatible. Are there any reasons you don't want to support Java 6?

Cheers,
Felix
@yurishkuro
Copy link
Member

I have no objections. I assume there's no performance degradation from running on bytecode generated by v6 vs. v7. And I don't think we're using any special features / APIs.

Can you submit a PR?

@felixbarny
Copy link
Contributor Author

Yes, I can do this.

felixbarny pushed a commit to felixbarny/jaeger-client-java that referenced this issue Mar 11, 2017
Java 6 compatibility
10f378a 
Checked with IntelliJ:
Run Inspection by Name >
Usages of API which isn't available at the configured language level

jaeger-crossdock still requires Java 7 because it calls
InetAddress#getLoopbackAddress()

(closes jaegertracing#129)
@felixbarny felixbarny mentioned this issue Mar 11, 2017
Merged
vprithvi pushed a commit that referenced this issue Mar 21, 2017
@felixbarny @vprithvi
Java 6 compatibility (#132)
7839d9f 
jaeger-crossdock still requires Java 7 because it calls
InetAddress#getLoopbackAddress()

Add animal sniffer plugin

(closes #129)
@isaachier isaachier mentioned this issue Aug 8, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Java 6 compatibility felixbarny/jaeger-client-java
2 participants
@felixbarny @yurishkuro