Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Does it make sense to use gzip compression for Thrift HTTP senders? #225

Closed
yurishkuro opened this issue Jul 28, 2017 · 1 comment
Closed

Comments

@yurishkuro
Copy link
Member

This change https://github.com/uber/jaeger/pull/282 allows gzip, but perhaps it's only useful when submitting spans as JSON.

@pavolloffay
Copy link
Member

The linked PR is related to zipkin. I am not sure if we want to implement it in our zipkinSender. However our ZipkinSender is a wrapper around arbitrary zipkin sender so Gzip encoding could be used.

#399 will introduce zipkin reporter (v2) so that any sender could be used.

I will close it. Please reopen if this is for jaeger http sender.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants