Zipkin v2 JSON Sender

[keitwb]

I would like to be able to send spans to Zipkin's v2 JSON API.

I've started on a new sender in the com.uber.jaeger.senders.zipkin package which I intend to contribute, but wanted to make sure I didn't overlook anything that already enables this or get any feedback on how I should do it. Unfortunately Zipkin 1/2 use a different interface for zipkin Sender so I will have to either have some duplicated code or write adapters to make them interchangeable.

[codefromthecrypt]

The zipkin v2 reporter can also send in v1 format. Other libraries switch to this for both variants https://github.com/openzipkin/zipkin-reporter-java/blob/master/README.md#legacy-encoding

…

On Tue, 10 Apr 2018, 22:42 Ben Keith, ***@***.***> wrote: I would like to be able to send spans to Zipkin's v2 JSON API. I've started on a new sender in the com.uber.jaeger.senders.zipkin package which I intend to contribute, but wanted to make sure I didn't overlook anything that already enables this or get any feedback on how I should do it. Unfortunately Zipkin 1/2 use a different interface for zipkin Sender so I will have to either have some duplicated code or write adapters to make them interchangeable. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#383>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD616-s9RGAk4D_n76SPlh3WqCg6CHHks5tnMTEgaJpZM4TOZkB> .