Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Do not use deprecated APIs internally #412

Merged

Conversation

pavolloffay
Copy link
Member

This is not a breaking change! It does not introduces/removes any APIs or implementation. It only removes calls to deprecated APIs from internal packages.

Signed-off-by: Pavol Loffay ploffay@redhat.com

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@ghost ghost assigned pavolloffay May 15, 2018
@ghost ghost added the review label May 15, 2018
@codecov
Copy link

codecov bot commented May 15, 2018

Codecov Report

Merging #412 into master will decrease coverage by 2.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #412      +/-   ##
============================================
- Coverage     84.25%   82.24%   -2.02%     
+ Complexity      500      487      -13     
============================================
  Files            66       66              
  Lines          2033     2033              
  Branches        247      247              
============================================
- Hits           1713     1672      -41     
- Misses          239      280      +41     
  Partials         81       81
Impacted Files Coverage Δ Complexity Δ
...ava/io/jaegertracing/reporters/RemoteReporter.java 82.35% <0%> (-2.36%) 7 <0> (-1)
...aegertracing/samplers/RemoteControlledSampler.java 78.78% <0%> (-6.07%) 18 <0> (-1)
...ava/io/jaegertracing/metrics/StatsFactoryImpl.java 0% <0%> (-58.34%) 0% <0%> (-3%)
...o/jaegertracing/metrics/InMemoryStatsReporter.java 0% <0%> (-38.47%) 0% <0%> (-3%)
...va/io/jaegertracing/metrics/NullStatsReporter.java 0% <0%> (-25%) 0% <0%> (-1%)
...main/java/io/jaegertracing/senders/HttpSender.java 80.95% <0%> (-9.53%) 6% <0%> (-2%)
...rc/main/java/io/jaegertracing/metrics/Metrics.java 71.73% <0%> (-8.7%) 11% <0%> (-2%)
.../src/main/java/io/jaegertracing/Configuration.java 80.58% <0%> (-1.62%) 33% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4386282...13e2de7. Read the comment docs.

@pavolloffay
Copy link
Member Author

The coverage is just wrong :). I haven't added new code

@pavolloffay pavolloffay merged commit 6f75dfe into jaegertracing:master May 15, 2018
@ghost ghost removed the review label May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants