Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Fix version retrieval from jaeger.properties #478

Merged

Conversation

jpkrohling
Copy link
Collaborator

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Which problem is this PR solving?

Short description of the changes

  • Removed jaeger.properties and fixed path to it, as it's now under internal

After this patch is applied, this is the expected output from the Jaeger tracer:

2018-07-05 16:15:11.355  INFO 27873 --- [ost-startStop-1] io.jaegertracing.Configuration           : Initialized tracer=JaegerTracer(version=Java-0.30.1-SNAPSHOT, serviceName=customer, reporter=CompositeReporter(reporters=[RemoteReporter(queueProcessor=RemoteReporter.QueueProcessor(open=true), sender=UdpSender(udpTransport=ThriftUdpTransport(socket=java.net.DatagramSocket@3ce7f19e, receiveBuf=null, receiveOffSet=-1, receiveLength=0)), closeEnqueueTimeout=1000), LoggingReporter(logger=Logger[io.jaegertracing.internal.reporters.LoggingReporter])]), sampler=ConstSampler(decision=true, tags={sampler.type=const, sampler.param=true}), ipv4=-1062686141, tags={hostname=caju.kroehling.de, jaeger.version=Java-0.30.1-SNAPSHOT, ip=192.168.178.67}, zipkinSharedRpcSpan=false, baggageSetter=io.jaegertracing.internal.baggage.BaggageSetter@775b0f05, expandExceptionLogs=false)

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@ghost ghost assigned jpkrohling Jul 5, 2018
@ghost ghost added the review label Jul 5, 2018
@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #478 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #478   +/-   ##
=========================================
  Coverage     88.14%   88.14%           
  Complexity      490      490           
=========================================
  Files            62       62           
  Lines          1848     1848           
  Branches        241      241           
=========================================
  Hits           1629     1629           
  Misses          142      142           
  Partials         77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a287b...527b1ce. Read the comment docs.

@jpkrohling jpkrohling merged commit 527b1ce into jaegertracing:master Jul 5, 2018
@ghost ghost removed the review label Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to internal broke the way we retrieve version from jaeger.properties
2 participants