Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Mark gson field in HttpSamplingManager as ignored for toString #528

Merged

Conversation

jpkrohling
Copy link
Collaborator

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Which problem is this PR solving?

Before:

2018-08-22 10:29:09 INFO Configuration:231 - Initialized tracer=JaegerTracer(version=Java-0.30.4, serviceName=vertx-create-span, reporter=RemoteReporter(queueProcessor=RemoteReporter.QueueProcessor(open=true), sender=UdpSender(udpTransport=ThriftUdpTransport(socket=java.net.DatagramSocket@b9387eb, receiveBuf=null, receiveOffSet=-1, receiveLength=0)), closeEnqueueTimeout=1000), sampler=RemoteControlledSampler(maxOperations=2000, serviceName=vertx-create-span, manager=HttpSamplingManager(gson={serializeNulls:false,factories:[Factory[typeHierarchy=com.google.gson.JsonElement,adapter=com.google.gson.internal.bind.TypeAdapters$29@579d530e], com.google.gson.internal.bind.ObjectTypeAdapter$1@2dc6b149, com.google.gson.internal.Excluder@403cd3a7, Factory[type=java.lang.String,adapter=com.google.gson.internal.bind.TypeAdapters$16@5ee2dbb7], Factory[type=java.lang.Integer+int,adapter=com.google.gson.internal.bind.TypeAdapters$7@635ae646], Factory[type=java.lang.Boolean+boolean,adapter=com.google.gson.internal.bind.TypeAdapters$3@7b0e5f9d], Factory[type=java.lang.Byte+byte,adapter=com.google.gson.internal.bind.TypeAdapters$5@5d091ab0], Factory[type=java.lang.Short+short,adapter=com.google.gson.internal.bind.TypeAdapters$6@15fe5dc5], Factory[type=java.lang.Long+long,adapter=com.google.gson.internal.bind.TypeAdapters$11@2122e1ea], Factory[type=java.lang.Double+double,adapter=com.google.gson.Gson$1@28d9b0e4], Factory[type=java.lang.Float+float,adapter=com.google.gson.Gson$2@3d90e3d5], Factory[type=java.lang.Number,adapter=com.google.gson.internal.bind.TypeAdapters$14@5a6781d7], Factory[type=java.util.concurrent.atomic.AtomicInteger,adapter=com.google.gson.TypeAdapter$1@6cfc06c0], Factory[type=java.util.concurrent.atomic.AtomicBoolean,adapter=com.google.gson.TypeAdapter$1@9c7c52b], Factory[type=java.util.concurrent.atomic.AtomicLong,adapter=com.google.gson.TypeAdapter$1@33f3018d], Factory[type=java.util.concurrent.atomic.AtomicLongArray,adapter=com.google.gson.TypeAdapter$1@557c471d], Factory[type=java.util.concurrent.atomic.AtomicIntegerArray,adapter=com.google.gson.TypeAdapter$1@593a8174], Factory[type=java.lang.Character+char,adapter=com.google.gson.internal.bind.TypeAdapters$15@6ee3e9e5], Factory[type=java.lang.StringBuilder,adapter=com.google.gson.internal.bind.TypeAdapters$19@453762dd], Factory[type=java.lang.StringBuffer,adapter=com.google.gson.internal.bind.TypeAdapters$20@72c491c9], Factory[type=java.math.BigDecimal,adapter=com.google.gson.internal.bind.TypeAdapters$17@7ff88fc4], Factory[type=java.math.BigInteger,adapter=com.google.gson.internal.bind.TypeAdapters$18@ea5ed1f], Factory[type=java.net.URL,adapter=com.google.gson.internal.bind.TypeAdapters$21@70fa579c], Factory[type=java.net.URI,adapter=com.google.gson.internal.bind.TypeAdapters$22@26e6da93], Factory[type=java.util.UUID,adapter=com.google.gson.internal.bind.TypeAdapters$24@1ddbe724], Factory[type=java.util.Currency,adapter=com.google.gson.TypeAdapter$1@3cb73c95], Factory[type=java.util.Locale,adapter=com.google.gson.internal.bind.TypeAdapters$28@1ed3da28], Factory[typeHierarchy=java.net.InetAddress,adapter=com.google.gson.internal.bind.TypeAdapters$23@e71b923], Factory[type=java.util.BitSet,adapter=com.google.gson.TypeAdapter$1@4c519d0e], com.google.gson.internal.bind.DateTypeAdapter$1@49074385, Factory[type=java.util.Calendar+java.util.GregorianCalendar,adapter=com.google.gson.internal.bind.TypeAdapters$27@4905c217], com.google.gson.internal.bind.TimeTypeAdapter$1@4a3ec2b5, com.google.gson.internal.bind.SqlDateTypeAdapter$1@ac79f11, com.google.gson.internal.bind.TypeAdapters$26@792feea7, com.google.gson.internal.bind.ArrayTypeAdapter$1@1edd9eef, Factory[type=java.lang.Class,adapter=com.google.gson.TypeAdapter$1@224adceb], com.google.gson.internal.bind.CollectionTypeAdapterFactory@1443e0a4, com.google.gson.internal.bind.MapTypeAdapterFactory@129f7e5d, com.google.gson.internal.bind.JsonAdapterAnnotationTypeAdapterFactory@6047b007, com.google.gson.internal.bind.TypeAdapters$30@141e8560, com.google.gson.internal.bind.ReflectiveTypeAdapterFactory@1fd30187],instanceCreators:{}}, hostPort=localhost:5778), metrics=io.jaegertracing.internal.metrics.Metrics@7657e9b6, sampler=ProbabilisticSampler(positiveSamplingBoundary=9223372036854776, negativeSamplingBoundary=-9223372036854776, samplingRate=0.001, tags={sampler.type=probabilistic, sampler.param=0.001})), ipv4=-1062731769, tags={hostname=caju.kroehling.de, jaeger.version=Java-0.30.4, ip=192.168.0.7}, zipkinSharedRpcSpan=false, baggageSetter=io.jaegertracing.internal.baggage.BaggageSetter@2b4da8f3, expandExceptionLogs=false)

Short description of the changes

After

2018-08-22 10:33:50 INFO Configuration:231 - Initialized tracer=JaegerTracer(version=Java-0.30.5-SNAPSHOT, serviceName=vertx-create-span, reporter=RemoteReporter(queueProcessor=RemoteReporter.QueueProcessor(open=true), sender=UdpSender(udpTransport=ThriftUdpTransport(socket=java.net.DatagramSocket@44f18aee, receiveBuf=null, receiveOffSet=-1, receiveLength=0)), closeEnqueueTimeout=1000), sampler=RemoteControlledSampler(maxOperations=2000, serviceName=vertx-create-span, manager=HttpSamplingManager(hostPort=localhost:5778), metrics=io.jaegertracing.internal.metrics.Metrics@5b6394c, sampler=ProbabilisticSampler(positiveSamplingBoundary=9223372036854776, negativeSamplingBoundary=-9223372036854776, samplingRate=0.001, tags={sampler.type=probabilistic, sampler.param=0.001})), ipv4=-1062731769, tags={hostname=caju.kroehling.de, jaeger.version=Java-0.30.5-SNAPSHOT, ip=192.168.0.7}, zipkinSharedRpcSpan=false, baggageSetter=io.jaegertracing.internal.baggage.BaggageSetter@5aa9aa1, expandExceptionLogs=false)

@ghost ghost assigned jpkrohling Aug 22, 2018
@ghost ghost added the review label Aug 22, 2018
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling force-pushed the Mark-gson-field-as-ignored branch from 68de90e to 6060f4b Compare August 22, 2018 08:39
@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #528 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #528   +/-   ##
=========================================
  Coverage     88.42%   88.42%           
  Complexity      505      505           
=========================================
  Files            66       66           
  Lines          1883     1883           
  Branches        239      239           
=========================================
  Hits           1665     1665           
  Misses          142      142           
  Partials         76       76
Impacted Files Coverage Δ Complexity Δ
...tracing/internal/samplers/HttpSamplingManager.java 100% <100%> (ø) 6 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e248ce0...6060f4b. Read the comment docs.

@jpkrohling jpkrohling merged commit 6060f4b into jaegertracing:master Aug 22, 2018
@ghost ghost removed the review label Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants