Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Exclude transitive Apache httpclient dependencies from libthrift #596

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

t-8ch
Copy link
Contributor

@t-8ch t-8ch commented Mar 1, 2019

See #516

See jaegertracing#516

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@de.amadeus.com>
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #596 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #596      +/-   ##
============================================
- Coverage     89.53%   89.27%   -0.26%     
+ Complexity      542      540       -2     
============================================
  Files            68       68              
  Lines          1949     1949              
  Branches        251      251              
============================================
- Hits           1745     1740       -5     
- Misses          129      133       +4     
- Partials         75       76       +1
Impacted Files Coverage Δ Complexity Δ
...rtracing/internal/reporters/CompositeReporter.java 71.42% <0%> (-28.58%) 6% <0%> (-1%)
...gertracing/internal/reporters/LoggingReporter.java 81.81% <0%> (-9.1%) 4% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167ecd6...247bacf. Read the comment docs.

@yurishkuro yurishkuro merged commit df3f205 into jaegertracing:master Mar 1, 2019
@yurishkuro
Copy link
Member

nice!

@t-8ch t-8ch deleted the remove-deps branch March 1, 2019 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants