Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add public method isFinished() on JaegerSpan #634

Merged
merged 2 commits into from
Aug 3, 2019
+12 −0
Merged

Add public method isFinished() on JaegerSpan #634

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0e0099
Add public method isFinished() on JaegerSpan
dougEfresh May 30, 2019
d290ed2
Adding sync block around isFinished for JaegerSpan
dougEfresh Aug 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jaeger-core/src/main/java/io/jaegertracing/internal/JaegerSpan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ public long getStart() {
return startTimeMicroseconds;
}

public boolean isFinished() {
return finished;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs synchronized (this), see finish() method

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

}

public long getDuration() {
synchronized (this) {
return durationMicroseconds;
Expand Down
6 changes: 6 additions & 0 deletions jaeger-core/src/test/java/io/jaegertracing/internal/JaegerSpanTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ public void testSetNumberTag() {
assertEquals(expected, jaegerSpan.getTags().get(key));
}

@Test
public void testFinished() {
jaegerSpan.finish();
assertTrue(jaegerSpan.isFinished());
}

@Test
public void testSetTag() {
jaegerSpan.setTag(new StringTag("stringTag"), "stringTagValue")
Expand Down