This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Bump okhttp version and zipkin reporter #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
commented
Dec 12, 2019
| compile group: 'org.apache.thrift', name: 'libthrift', version: apacheThriftVersion | ||
|
|
||
| testCompile group: 'io.zipkin.zipkin2', name: 'zipkin-junit', version: '2.9.4' | ||
| testCompile group: 'io.zipkin.zipkin2', name: 'zipkin-junit', version: '2.19.2' |
There was a problem hiding this comment.
This is required as zipkin uses okhttp mock server.
pavolloffay
commented
Dec 12, 2019
| @@ -3,10 +3,10 @@ description = 'Integration library for Zipkin' | |||
| dependencies { | |||
| compile project(':jaeger-client') | |||
|
|
|||
| compile group: 'io.zipkin.reporter2', name: 'zipkin-sender-urlconnection', version: '2.7.6' | |||
| compile group: 'io.zipkin.reporter2', name: 'zipkin-sender-urlconnection', version: '2.12.0' | |||
There was a problem hiding this comment.
This is not required just bumping to a newer version.
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=========================================
Coverage 89.83% 89.83%
Complexity 569 569
=========================================
Files 69 69
Lines 2086 2086
Branches 266 266
=========================================
Hits 1874 1874
Misses 131 131
Partials 81 81Continue to review full report at Codecov.
|
objectiser
approved these changes
Dec 12, 2019
Closed
pavolloffay
added a commit
that referenced
this pull request
Dec 17, 2019
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.