-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GRPC storage plugin #1517
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1517 +/- ##
==========================================
- Coverage 87.93% 87.93% -0.01%
==========================================
Files 92 93 +1
Lines 5778 5811 +33
==========================================
+ Hits 5081 5110 +29
- Misses 532 534 +2
- Partials 165 167 +2
Continue to review full report at Codecov.
|
I think we should add documentation on how this works. (something similar to the description of this PR) |
pkg/deployment/ingester_test.go
Outdated
@@ -5,6 +5,8 @@ import ( | |||
"strings" | |||
"testing" | |||
|
|||
"github.com/stretchr/testify/require" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the import order here is not correct, please verify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it passes CI check. We should perhaps use different tooling to catch this on CI
re docs- yes definitely I will add them to docs repo. |
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Resolves #1042
Supersedes #1045
How does it work:
User has to specify
grpc-plugin
asstorage.type
and image with the plugin binary instorage.grpcPlugin.image
. The image has to copy plugin binary into/plugin/
directory. At the moment this is not configurable. If there will be requests we could make that configurable in the CR.The image is used for init container. At jaeger startup the init container copies the plugin binary into volume. This makes the binary visible to Jaeger.
The flags for the storage plugin (bibary, configuration-file, log-level) are provided in
storage.options
, to be consistent with other storage implementations. The configuration file for the storage plugin has to be explicitly configured in storage volumes as a config map (the user is responsible for creating it).This PR does not contain e2e tests. The e2e tests will be added in a separate PR.