Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ingester deadlock interval to inf (0) #1867

Closed
pavolloffay opened this issue Oct 18, 2019 · 2 comments · Fixed by #1868
Closed

Change ingester deadlock interval to inf (0) #1867

pavolloffay opened this issue Oct 18, 2019 · 2 comments · Fixed by #1868
Assignees

Comments

@pavolloffay
Copy link
Member

#1134 introduced

--ingester.deadlockInterval duration Interval to check for deadlocks. If no messages gets processed in given time, ingester app will exit. Value of 0 disables deadlock check. (default 1m0s)

@yurishkuro why the default is 1 minute? Could it be changed to 0? The problem is that people usually deploy Jaeger and do not immediately start sending data. With the current default value the ingester dies and it is restarted with exponential backoff (in k8s) which is not ideal.

@yurishkuro
Copy link
Member

Yes, seems reasonable not to make this the default behavior.

@vprithvi
Copy link
Contributor

I think this is a reasonable change - there is no good reason to have the default be 1 minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants