-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usages of GetStorageFactory
#6564
Comments
@mahadzaryab1 Can you provide some resources to get started on v2. Also, what are the changes from v1 to v2 |
@mahadzaryab1, I am interested in this issue. Can you assign it to me? |
Hey @mahadzaryab1, I'm fairly new to the repository. Is this issue open for contributions? I read a bit through the v2 proposal and the parent issue. From what I understand, we want to change func (f *Factory) Purge(ctx context.Context) error {
p, ok := f.ss.(storage_v1.Purger)
if !ok {
// storage backend doesn't implement Purger
}
err := p.Purge(ctx)
return err
} Am I on the right path? |
hey @mahadzaryab1 but storage_v1 dosent have a |
We have two remaining usages of
jaegerstorage.GetStorageFactory
, which provide the v1 factory:We want to remove these and find a way to get the same functionality using the v2 factory.
The text was updated successfully, but these errors were encountered: