Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Zipkin backports to another repository? #807

Open
yurishkuro opened this issue May 5, 2018 · 3 comments
Open

Move Zipkin backports to another repository? #807

yurishkuro opened this issue May 5, 2018 · 3 comments

Comments

@yurishkuro
Copy link
Member

#518 introduced a pretty large, and largely unnecessary, dependency on github.com/go-openapi/* packages (https://github.com/jaegertracing/jaeger/pull/518/files#diff-395f41b2a27b70ce44399c91c82158c2R45).

What if we moved all Zipkin-related code into another repository and have people run it as a sidecar instead of being part of the main Jaeger collector?

Alternatively, we should consider if we really need all these runtime dependencies on github.com/go-openapi/* - in the end all we're doing is implementing a single POST /api/traces endpoint and converting from Zipkin model to Jaeger. The endpoint implementation does not require go-openapi mechanics, the only thing that's needed is generating the data model from zipkin swagger file, which can be done offline.

cc @pavolloffay

@pavolloffay
Copy link
Member

What if we moved all Zipkin-related code into another repository and have people run it as a sidecar instead of being part of the main Jaeger collector?

What do you mean exactly? Have a separate zipkin-collector importing jaeger?

IIRC openapi dependencies are used to generate and validate the model.

@jpkrohling
Copy link
Contributor

jpkrohling commented May 8, 2018

What if we moved all Zipkin-related code into another repository and have people run it as a sidecar instead of being part of the main Jaeger collector?

Interesting idea. This is actually how NATS export their Prometheus metrics: they have a sidecar that makes the bridge between Prometheus and NATS, translating the internal metrics format into Prometheus'.

Reference: https://github.com/nats-io/prometheus-nats-exporter

@yurishkuro
Copy link
Member Author

What do you mean exactly? Have a separate zipkin-collector importing jaeger?

not collector, a bridge that consumes zipkin formats and forwards to jaeger-collector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants