We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: Insecure temporary file creation methods should not be used.
var tempZipName = Path.GetTempFileName(); var tempEntryName = Path.GetTempFileName();
Solution:
var tempFolderPath = Path.GetTempPath(); var tempZipName = Path.Combine(tempFolderPath, Path.GetRandomFileName()); var tempEntryName = Path.Combine(tempFolderPath, Path.GetRandomFileName());
Problem: CodePagesEncodingProvider is not available in .NET 4.8
CodePagesEncodingProvider
CodePagesEncodingProvider.Instance.GetEncoding(437); Encoding.RegisterProvider(CodePagesEncodingProvider.Instance); DefaultEncoding = Encoding.GetEncoding(437);
Solution: Use condition to exclude code for .NET 48 build:
#if NET5_0_OR_GREATER CodePagesEncodingProvider.Instance.GetEncoding(437); Encoding.RegisterProvider(CodePagesEncodingProvider.Instance); #endif DefaultEncoding = Encoding.GetEncoding(437);
The text was updated successfully, but these errors were encountered:
Please see my comment in #52 regarding CP 437 I will incorporate your suggestion about temporary files once the previous is resolved.
Sorry, something went wrong.
No branches or pull requests
Security Issue
Problem: Insecure temporary file creation methods should not be used.
Solution:
.NET 4.8 Compatibility issue
Problem:
CodePagesEncodingProvider
is not available in .NET 4.8Solution: Use condition to exclude code for .NET 48 build:
The text was updated successfully, but these errors were encountered: