Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration extension #168

Open
m0mus opened this issue Jul 25, 2019 · 5 comments
Open

Configuration extension #168

m0mus opened this issue Jul 25, 2019 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@m0mus
Copy link
Contributor

m0mus commented Jul 25, 2019

JSONB is configured using annotations at compile time and JsonbConfig class at runtime. Runtime configuration currently doesn't cover many aspects covered by annotations. The goal is to extend JSONB runtime configuration the way that it allows to configure everything that annotations allow plus a little bit more.

Goals:

@m0mus m0mus added the enhancement New feature or request label Jul 25, 2019
@m0mus m0mus added this to the 2.0 milestone Jul 25, 2019
@aguibert
Copy link
Contributor

I think this is a good idea and we should work on this for 2.0.

Seems like a duplicate of #88 though, do you agree @m0mus?

@m0mus
Copy link
Contributor Author

m0mus commented Jul 29, 2019

@aguibert I would say it's a superset of #88. :)

@aguibert
Copy link
Contributor

I think the first bullet point is pretty much the same as #88

Extend JsonbConfig functionality to cover all functionality provided by @JsonbXXX annotations

The second bullet point is the delta:

Integrate with MicroProfile Configuration or with Jakarta Configuration if available

Are you OK with repurposing this item to be just for the second bullet point?

@m0mus
Copy link
Contributor Author

m0mus commented Jul 31, 2019

@aguibert It's fine. I just wanted to have one issue for all configuration related issues. Feel free to changing it to the second bullet only.

@aguibert
Copy link
Contributor

aguibert commented Aug 2, 2019

having a parent issue is fine -- I've raised #172 and linked it to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants