-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't use polyfill since v2.0 #75
Comments
Are we supposed to activate the polyfill manually now? ES6Promise.polyfill() This doesn't seem to be documented in the README, nor the CHANGELOG, nor is there any GitHub Relase notes https://github.com/jakearchibald/es6-promise/releases/tag/2.0.0 |
Thanks @mislav could not for the heck of me find why Promise was still working in chrome but not IE after updating... |
+1 |
+1 ran into this today. |
var Promise = Promise || ES6Promise.Promise; << this will help |
So it doesn't require a loader, but it will use one when available. Would you prefer it always expose a global? |
this is an old version, the latest auto-polyfils https://github.com/jakearchibald/es6-promise/blob/master/lib/es6-promise.umd.js#L18 |
@jakearchibald can we got another release, this is fixed on master. |
If the library is supposed to auto-polyfill, then we'd like to have another 2.x release where this is fixed. If the decision was made to not auto-polyfill, then I'd like to see documentation on how to activate the polyfill ourselves. Then this issue can be closed. Thanks! |
+1 for docs about the library not auto-polyfilling. Confused me for a few moments also. |
We were using require, but it wasn't doing what it would be expected to do. Now we are using the no-require polyfill initialization. stefanpenner/es6-promise#75
we auto-polyfil. @jakearchibald can we get a release this weekend? |
is new |
yup, pending a release. I don't think i have all the creds needed to releasing. |
Will do a release today, cheers! |
Done |
README still instructs that we need to do |
Also, I'm trying to evaluate whether we want to upgrade v1.0.0 to v2.1.0 on github.com. Since CHANGELOG has been eviscerated b301f17, could we maybe ask that release notes be added to Releases for this project? Like, which exact bugs have been fixed, in which cases is the new version more performant, etc. Thanks. |
Sure. I'll try to find more time. The quick answer is lots of bug fixes and performance work. |
Requiring
promise.js
doesn't polyfill Promise since version 2.0 as it seems it requires a JavaScript loader now.Version 1.0 of the polyfill could be used as normal JavaScript:
This was broken in v2.0.
The text was updated successfully, but these errors were encountered: