Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 6.2.2 problem with redirection after login #731

Closed
Mori22 opened this issue Aug 30, 2017 · 12 comments
Closed

Version 6.2.2 problem with redirection after login #731

Mori22 opened this issue Aug 30, 2017 · 12 comments

Comments

@Mori22
Copy link

Mori22 commented Aug 30, 2017

Hi,

I did just install Bonobo Server Version 6.2.2 (Windows Server 2012 R2).

The installation itself went without any problems and I see the login screen when i open

http://localhost/Bonobo.Git.Server

When I now enter the default admin details I get an error 404 page that the requested page was not found. The URL of this page is:

http://localhost/Home/Index

which does not exist.

When i manually enter the URL

http://localhost/Bonobo.Git.Server/Home/Index

I get the correct page and am logged in.

So my guess is that the returnURL on the Login page is somehow wrong. Currently it is set to:

?returnUrl=%2FHome%2FIndex

I did try to install the Git Server on a freshly installed server (Windows Server 2016) with the same result.

I was unable to find a compiled version of a previous version of bonobo so I am unable to test whether this issue is specific to my setup or a general problem with version 6.2.2.

@willdean
Copy link
Collaborator

@Mori22 You can find older versions (no index, but the binaries are there) at URLs like this:

https://bonobogitserver.com/resources/releases/6_2_1.zip

A complete list of everything that's up there is here:

https://github.com/jakubgarfield/Bonobo-Git-Server-Web/tree/master/content/resources/releases

If you do find an earlier version works better then that would be interesting.

You will find that prior to 6.x the database format is different, so it's hard to go back that far without restarting on the database.

@Mori22
Copy link
Author

Mori22 commented Aug 30, 2017

@willdean I did try the Version 6.2.1 and didn't have problem with the redirection:

When I enter the admin credentials i get redirected to the correct page

When I checked the ReturnUrl in Version 6.2.1 the value there is:

ReturnUrl=%2FBonobo.Git.Server%2FHome%2FIndex

So my guess would be that the issue i described is problem within version 6.2.2 and could be relevant for any user who updates to this version.

Anyway I will just stick to Version 6.2.1 until the issue is resolved.

@willdean
Copy link
Collaborator

@Mori22 Thanks for checking this - I suspect this is perhaps something to do with #710 - I'll have a look.

@willdean
Copy link
Collaborator

@jeffgaroutte would you mind having a look at this and see if you think anything in #710 might be involved?

@oharab
Copy link

oharab commented Aug 31, 2017

Is the issue with the RepositoryController not taking into account any virtual directories.
return RedirectToAction("Logon", "Home", new { returnUrl="/Home/Index" });

@Guido11
Copy link

Guido11 commented Aug 31, 2017

I experience the same problem
Version 6.2.1 works fine and the login page redirects to the right page in ReturnURL
https://testcodesafe.chsys.org/Bonobo.Git.Server/Home/LogOn?ReturnUrl=%2FBonobo.Git.Server%2F

Version 6.2.2 redirect to a different location Home/Index
https://testcodesafe.chsys.org/Bonobo.Git.Server/Home/Logon?returnUrl=%2FHome%2FIndex

@willdean
Copy link
Collaborator

willdean commented Sep 1, 2017

@oharab Thanks - I think you're right - it should be using a method to create the URL, not just a text string.

@willdean
Copy link
Collaborator

willdean commented Sep 1, 2017

I've just posted a PR which should address this - once AppVeyor's built it, would anyone who's struggling with this be able to download the zip from the AppVeyor artefacts and try it out?

@Mori22
Copy link
Author

Mori22 commented Sep 3, 2017

@willdean would love to test it but there seems to be a problem with the changes as AppVeyor just outputs an error and no usable zip files

@willdean
Copy link
Collaborator

willdean commented Sep 4, 2017

@Mori22 Yes, the unit tests are broken, sorry. I am struggling to make time to deal with this at the moment, but will post here again when it's fixed.

@Mori22
Copy link
Author

Mori22 commented Sep 4, 2017

@willdean don't worry this isn't a big deal as version 6.2.1 runs perfectly stable. If anything you deserve praise for reacting so fast at all!

@jeffgaroutte
Copy link
Contributor

line 44 should be
return RedirectToAction("Logon", "Home", new { returnUrl= Url.Action("index", "Home") });

that should address the unit test issue and virtual directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants