Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put back functionality in moto based tests #10

Closed
jamesabel opened this issue May 5, 2023 · 1 comment
Closed

put back functionality in moto based tests #10

jamesabel opened this issue May 5, 2023 · 1 comment
Assignees
@jamesabel
Labels
enhancement New feature or request

Comments

@jamesabel
Copy link
Owner

jamesabel commented May 5, 2023 •
edited
Loading

Due to an AWS/boto change, several awsimple tests no longer work when using moto to mock AWS. This seems to mainly be around SQS. See getmoto/moto#6286 for details.

As a temporary workaround I put if not is_mock(): to gate the execution of several tests (mainly SQS tests). This was necessary to get CI/CD (GitHub Actions) to pass.

Once this is resolved, go back through all the tests and remove the if not is_mock(): where possible. Again, this will probably be for the SQS tests.

Note that using regular AWS (not moto) performs all the testing. It is recommended to use regular AWS frequently until this is resolved.
@jamesabel jamesabel added the enhancement New feature or request label May 5, 2023
@jamesabel jamesabel self-assigned this May 5, 2023
@jamesabel
Copy link
Owner Author

Resolved in #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesabel jamesabel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamesabel