[modal_bottom_sheet]: Invalid/unused API's on closeProgressThreshold and preventPopThreshold

[Juliotati]

After using the package for a while and attempting to have a different value for closeProgressThreshold, I noticed that the value passed in was not being reflected on the behaviour of the bottom sheet. So I dug in and found these.

1.

modal_bottom_sheet/modal_bottom_sheet/lib/src/bottom_sheet.dart

Lines 48 to 54 in e44458d

	double? closeProgressThreshold,
	@Deprecated('Use preventPopThreshold instead') double? willPopThreshold,
	double? preventPopThreshold,
	}) : preventPopThreshold =
	preventPopThreshold ?? willPopThreshold ?? _willPopThreshold,
	closeProgressThreshold =
	closeProgressThreshold ?? _closeProgressThreshold;

• willPopThreshold was deprecated in place of preventPopThreshold
• preventPopThreshold is never used anywhere in the class state

• (flingThreshold seems to be a more suitable name)

• From the docs, it seems like what users are looking is closeProgressThreshold, but that's not true either because that is not the variable that is used to determine whether or not the bottom sheet should close. 👇 (at least from what I noticed, closeProgressThreshold isn't really doing what it entails 😢 )

2.

modal_bottom_sheet/modal_bottom_sheet/lib/src/bottom_sheet.dart

Lines 160 to 161 in e44458d

	bool get hasReachedWillPopThreshold =>
	widget.animationController.value < _willPopThreshold;

• From the second snippet above it looks like what should be used here is widget.willPopThreshold and not the hardcoded _willPopThreshold but that doesn't help because the user can't change that anyway.
• So it would only make sense that closeProgressThreshold replaces willPopThreshold

Let me know if this is all clear to grasp. It does seem all too coupled hence the bug.

• Related issue (not much info there) closeProgressThreshold is not working in iOS. #152
• PR that attempted to fix but didn't reach the core closeProgressThreshold fix #126