Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to scrollTop 0 #201

Closed
satazor opened this issue Dec 5, 2013 · 1 comment · Fixed by #203
Closed

Unable to scrollTop 0 #201

satazor opened this issue Dec 5, 2013 · 1 comment · Fixed by #203
Labels
Bug

Comments

@satazor
Copy link
Contributor

satazor commented Dec 5, 2013

Issue is that 0 is evaluated to false here: https://github.com/jamesflorentino/nanoScrollerJS/blob/master/bin/javascripts/jquery.nanoscroller.js#L865

Possible solutions are typeof options.scrollTop === 'number' or options.scrollTop != null.

Same thing happens with scrollBottom.
@kristerkari
Copy link
Collaborator

Yup, need to fix that.

@adam101 adam101 mentioned this issue Dec 6, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix scrollTop and scrollBottom options. adam101/nanoScrollerJS
2 participants
@kristerkari @satazor