Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preventPageScrolling on touch devices #295

Open
erikhagreis opened this issue Apr 13, 2015 · 3 comments
Open

preventPageScrolling on touch devices #295

erikhagreis opened this issue Apr 13, 2015 · 3 comments

Comments

@erikhagreis
Copy link
Contributor

It seems there is no support for preventPageScrolling on touch devices. I have looked into the code, and cannot find logic in the preventScrolling function that handles events of type touchmove. There is only logic for `DOMMouseScroll' and 'wheel' events.

Am I missing anything? If not it would be feasible for me to create a pull request where also touch events are handled in this feature.

@kristerkari
Copy link
Collaborator

Yeah it is true because I guess nanoScroller was initially created with desktop browsers in mind.

If preventScrolling can be implemented so that it works consistently in mobile browsers, then there should be reason to support it as well.

@erikhagreis
Copy link
Contributor Author

I'm currently working on an implementation and learning a lot about how touchdevices handle scrolling. Once I understand enough of it I'll come back to this.

@kristerkari
Copy link
Collaborator

@erikhagreis sounds good! You should share your learnings when you are done :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants