Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec review 1 #2

Open
thaodt opened this issue Feb 12, 2025 · 2 comments
Open

Spec review 1 #2

thaodt opened this issue Feb 12, 2025 · 2 comments

Comments

@thaodt
Copy link

thaodt commented Feb 12, 2025

Hi James, thanks for writing this spec. It was really helpful in helping me understand what postcard & postcard-rpc are doing.
Below are some minor typos and a few questions I noticed.

The version I refer to 6763142

Typos:

Image
it should be "then" instead.

Image
I suppose should it be the Appendix B - The Postcard-RPC protocol ?

Queries

Image

I assume by "leb" here you are referring to "Little Endian Base 128" is that correct? Its a variable-length code compression used to store arbitrarily large integers in a small number of bytes.

  1. Regarding to " Serde Data Model", should we provide a link to clarify it for those unfamiliar with it maybe? for e.g. https://serde.rs/data-model.html

Image

Im just confused a bit, is it a TODO for you or ...?

Regarding to section 4 - Encoding of Serde Data Model Types & Appendix A & B, I will read them again before adding more reviews.

@jamesmunns
Copy link
Owner

Yup, as a disclaimer, I'm very much not done, this is a snapshot of a work in progress. I posted it because some people asked.

Review (and PRs!) are welcome, but I definitely wouldn't realy consider it at a stage where I'd be asking for proactive review!

@thaodt
Copy link
Author

thaodt commented Feb 13, 2025

I think I will continue reading & reviewing at this stage instead of PRs. Because you're the crates's author, I won't know what you planned to write.

I just state what I see while reading so you can update quickly. ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants