Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt6: Investigate UI glitches on Windows 11 and Mac #2363

Closed
hoffie opened this issue Feb 8, 2022 · 13 comments
Closed

Qt6: Investigate UI glitches on Windows 11 and Mac #2363

hoffie opened this issue Feb 8, 2022 · 13 comments
Labels
bug Something isn't working
Milestone

Comments

@hoffie
Copy link
Member

hoffie commented Feb 8, 2022

@ann0see noticed UI glitches in the Qt6 preview builds in #2299 (comment)_

  1. Strange lines:
    On Windows 11 there seem to be strange lines on the GUI which disappear on click. It looks as if one marked some invisible button:

image

image

  1. Another issue
    image

  2. A macOS issue (I doubt it's new):
    halleffekt
    The lines seem to be at the wrong position. On macOS I think Qt6 is an improvement (at least UI wise)

@hoffie hoffie added this to the Release 3.9.0 milestone Feb 8, 2022
@hoffie hoffie changed the title Qt6: Investigate UI glitches on Windows and Mac Qt6: Investigate UI glitches on Windows 11 and Mac Feb 8, 2022
@hoffie
Copy link
Member Author

hoffie commented Feb 8, 2022

@ann0see Thanks for the tests.

  1. Some questions
    a. Does this only happen with the fancy skin?
    b. Is this reproducible in your (@ann0see) machine / has anyone else observed this (@henkdegroot and @dcorson-ticino-com test runs, IIRC)?
    c. Does this happen with the Qt6 build on Windows 10?
    d. Does this happen with a Qt5 master build on Windows 11?

  2. I have a hard time figuring out what the problem is as multiple things look strange at first sight. Is it the overlapping of the "Trennen" button? Or the high ping? Or the scroll bar?

  3. Are you saying this is broken in the official Qt5-based builds as well? Then we should probably remove this here and make it a separate issue? I don't think I've seen that reported so far.

@hoffie hoffie mentioned this issue Feb 8, 2022
11 tasks
@henkdegroot
Copy link
Contributor

henkdegroot commented Feb 9, 2022

Not seeing these glitches on my Win11 system. Also tested if display scaling could cause this, but 100, 125 and 150% all looking good to me. Even checked with german language in case it was caused by text length differences. And I also checked a build with Qt5 and Qt6 and they behave the same on my win11.

@ann0see
Copy link
Member

ann0see commented Feb 9, 2022

  1. This can be reproduced. Qt5 doesn’t provoke these errors. I can’t test on Windows 10. I did not try the compact/normal skin yet.
  2. I didn’t even notice the high ping. Probably it‘s unrelated. I mainly focused on the white bar under the disconnect button.
  3. I tested the Qt5 build too and it’s a bit different; however I need to re-test it.

@henkdegroot
Copy link
Contributor

I have tested the Qt6 build on a second win11 system and no issue with the display of the GUI.
However I did notice my selected (saved) country/region changed. Previous version (with Qt5) installed, I had selected Netherlands. Now with Qt6 my country is Mayotte. Not sure which issue is best to report this at.

@pljones
Copy link
Collaborator

pljones commented Feb 9, 2022

However I did notice my selected (saved) country/region changed. Previous version (with Qt5) installed, I had selected Netherlands. Now with Qt6 my country is Mayotte. Not sure which issue is best to report this at.

Qt6 compatibility is the only place I can think that would have happened. The build you're running does have that included, yes?

@dcorson-ticino-com
Copy link
Contributor

However I did notice my selected (saved) country/region changed. Previous version (with Qt5) installed, I had selected Netherlands. Now with Qt6 my country is Mayotte.

Looks like it is reading a Qt5 locale in the ini file and interpreting it as Qt6, or something similar.
If you change to Netherlands, exit Jamulus and start Jamulus again is the problem still there?

@hoffie
Copy link
Member Author

hoffie commented Feb 9, 2022

I have tested the Qt6 build on a second win11 system and no issue with the display of the GUI. However I did notice my selected (saved) country/region changed. Previous version (with Qt5) installed, I had selected Netherlands. Now with Qt6 my country is Mayotte. Not sure which issue is best to report this at.

Thanks. Yes. I know about that part and the PR contains an open TODO item ( Do Country code conversion in Settings to ensure that updates continue working).

@henkdegroot
Copy link
Contributor

change to Netherlands, exit Jamulus and start Jamulus again is the problem still there?

Just to confirm, that the manual change, exit and start works. So just the TODO on the conversion part.

@ann0see ann0see added the bug Something isn't working label Feb 16, 2022
@hoffie
Copy link
Member Author

hoffie commented Apr 26, 2022

@ann0see Did I understand #2300 (comment) correctly that those glitches are no longer there on Windows since building with 6.3.0?

@ann0see
Copy link
Member

ann0see commented Apr 26, 2022

Yes – at least with the self compiled version.

@hoffie
Copy link
Member Author

hoffie commented Apr 26, 2022

Ok, maybe you can verify with the autobuild versions at some point and we could close this issue.

@ann0see
Copy link
Member

ann0see commented Apr 27, 2022

Yes. Windows 11 with the latest Qt version using the version from autobuild doesn't show these issues anymore. Still not sure about the iOS crash.

@ann0see
Copy link
Member

ann0see commented May 7, 2022

Closing this issue since the iOS crash is not related. Probably worth discussing in the linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants