Remove unused def #205
Merged
Remove unused def #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @sogaiu . I think this PR as well as a few others indicate we should have some linting for unused bindings, especially local bindings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following exists in netrepl.janet:
It looks like it may be safe to replace it with:
as there are no other relevant references to
f.This PR is a suggestion to make that replacement.
It appears
(def f ...)was needed at some point before, but when this change was made (may need to scroll up depending on browser settings), the code:was replaced with:
It seems that the last bit of code that needed to refer to
fwas removed in that change.