-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange/Glitchy navigation animations in Release 1.5.8 #133
Comments
This is fixed in the latest snapshot, as I fixed it in commit 2bb3fc3. If you want to use the latest version, replace the dependency with this: |
Thanks @daniel-stone for pointing that out. I think I should release a quick bug fix release soon. |
Thanks @daniel-stoneuk and @heinrichreimer for response. I tried the latest commit by replacing the dependency with the commit at |
@abhijitvalluri could you make another screen recording preferably with a higher frame rate so that we can see the glitch? |
Ah right, sorry for assuming it was fixed. I was having similar issues and that fixed it. |
Can you not just get the slide at an index and then call a public method (after checking instance of) to change the canGoForward variable? |
Yep, @daniel-stoneuk is right about that. If you want to change If you don't want to use a |
@daniel-stoneuk you can't modify a |
Ah yup, I was thinking of |
@daniel-stoneuk nor can you modify a |
You can only modify the |
The behavior with the latest commit was exactly the same as the one with From here on out, the logic in updatePosition() in I think there is no way to reliably fix this unless you make sure that I currently fixed my glitch by using FragmentSlide's instead of the Thanks for looking into this! |
@abhijitvalluri nice catch. I'll check out this issue with |
@heinrichreimer I did not use |
Yep, that should work |
@heinrichreimer That's what I meant... Of course 😂😂 |
Firstly, thanks for an amazingly detailed library! I am currently using it in my published app for the introduction setup.
Right now, my latest published app uses Release 1.5.5 of your library. This version seems to do fine with regard to the page navigation and the corresponding animations. Firstly, some context on my usage of your library: I have used multiple "SimpleSlide"s for my setup process. Some of these slides need to disable "CanGoForward" as the user is forced to click on the Cta button. The button issues an Intent that launches another app's activity and upon return to my app, in the onActivityResult, I retrieve the particular SimpleSlide, and replace it with an identical slide where "CanGoForward" is set to true. I haven't figured out a way to change a SimpleSlide's "CanGoForward" data member, so I had to replace it with a new Slide object. Then the user can press the forward button and continue.
Starting from 12th second, upon returning from the other app's activity + replacing slide with another that allows forward navigation, this is what happens: When I navigate forward by pressing the forward arrow, rather than a smooth transition, I see a sudden jump to the next Slide. Scrolling seems fine. However, on the next Slide, where "CanGoForward" is false again, scrolling causes the Slide's content to vanish (at 00:18 in 2nd video). Pressing the forward arrow disallows navigation as expected though. Pressing the back arrow causes some strange navigation animations that I can't quite explain.
Could you please look into this as I cannot currently use the latest version due to this strange animation issues?
The text was updated successfully, but these errors were encountered: