-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change API design to support Drawables/Colors/... instead of just resource IDs #193
Comments
This may be a thing to have in a major release as I would have to change the API to make the interaction as intuitive as possible. |
My clone currently does fully support this (inclusive fast and easy extension of views, for example adding a progress bar or a checkbox to the inner It's fine if you do it yourself as well when you have time, my clone is working perfectly fine for me now as well... |
Yeah, a PR would be great! |
@MFlisar If you’re able to submit a PR, we’d love that! |
Here's the according PR - #195 - it's already merged... And here's the renamed interface for the simple slide of the current master: https://github.com/heinrichreimer/material-intro/blob/master/library/src/main/java/com/heinrichreimersoftware/materialintro/slide/SimpleSlideActivity.java Inside the callbacks you can update your views to your liking as much as you want |
Currently you use a builder to setup the simple slide. As they are used for creating a fragment, you're limited in what you can define (like you can only define image resources, but can't define a drawable instead).
For surpassing this limitation, it would be nice to add an interface that the parent activity can implement and that can provide additional data (like for example a
Drawable
for the icon) and much more of course.What do you think about that?
This means, we can use the SimpeSlide for many more usecases and make it much more flexible, drawback is, me must add an id for each SimpleSlide to identify the slide in the interfaces functions...
PS: check out my repo clone, I have uploaded a very basic change already just to DEMONSTRATE what I mean. Changes are minimal currently...
The text was updated successfully, but these errors were encountered: