Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add model gpt-4 turbo #2836

Merged
merged 2 commits into from
May 6, 2024
Merged

feat: add model gpt-4 turbo #2836

merged 2 commits into from
May 6, 2024

Conversation

henryh0x1
Copy link
Contributor

@henryh0x1 henryh0x1 commented Apr 27, 2024

Describe Your Changes

  • This pull requests add the gpt-4 turbo to the model list. As a user, I prefer use GPT-4 Turbo rather than GPT-4 normal because it's recently cut off knowledge from April 2023, and cheaper price and better than the normal GPT 4 model.
  • Thus, I think it should be added to the default list. For the non-technical user, seems a little bit inconvenient as requires additional steps. This PR adds the GPT-4-Turbo model, so when users download it, they can use it without additional steps.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: feature request A new feature label Apr 27, 2024
@henryh0x1 henryh0x1 requested a review from a team April 27, 2024 09:56
@Van-QA Van-QA requested a review from hahuyhoang411 May 2, 2024 10:38
@Van-QA Van-QA force-pushed the feat/add-gpt-4-turbo branch from 8e25935 to 9420121 Compare May 4, 2024 08:44
@henryh0x1 henryh0x1 closed this May 4, 2024
@Van-QA Van-QA reopened this May 4, 2024
@Van-QA Van-QA force-pushed the feat/add-gpt-4-turbo branch from df5555f to 15a814a Compare May 6, 2024 03:42
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA merged commit 86fda1c into dev May 6, 2024
7 checks passed
@Van-QA Van-QA deleted the feat/add-gpt-4-turbo branch May 6, 2024 03:43
@github-actions github-actions bot added this to the v0.5.0 Broken Rice milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants