Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #669: Rollback pull requests #643 and #664 #670

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Fix issue #669: Rollback pull requests #643 and #664 #670

merged 1 commit into from
Aug 17, 2018

Conversation

raymond-lam
Copy link
Contributor

Pull requests #643 and #664 together fix the issue reported in issue #617, but the change in behavior is causing semvers concerns. See issue #669. Therefore, roll back #643 and #664 and later reintroduce in a major release.

@phillipj phillipj merged commit 5acafd3 into janl:master Aug 17, 2018
@raymond-lam raymond-lam deleted the issue669-1 branch August 17, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants