Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browser test suite by using Node.js 6 #667

Merged
merged 2 commits into from
Aug 2, 2018
Merged

Fix browser test suite by using Node.js 6 #667

merged 2 commits into from
Aug 2, 2018

Commits on Aug 2, 2018

  1. Fix browser tests by running them on Node.js 6 

    For a long time we've struggled getting the browser test suite to run
on sauce labs. Those tests were running on Node.js 4 which is getting
quite old.

In a trial-n-error effort, I tried adding Node.js 6 as one of the
versions to run on Travis CI, and at the same time ensure the browsers
tests were run on that version instead of Node.js 4 -- voila the suite
passed right away.

It therefore seemed like the issues we were seeing had to do with us
running those tests via Node.js 4.
    @phillipj
    phillipj committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    79c1ede View commit details
    Browse the repository at this point in the history

  2. Only install npm v2 on Travis CI when testing Node.js 0.8 

    For a long time, we've been installing npm v2.x before running tests
on Travis CI across all Node.js versions.

While doing some testing today, I observed that we were able to install
dependencies and run all tests just fine on all Node.js versions, except
for v0.8. Therefore ensure we only force an install of npm v2.x when
running tests on Node.js 0.8, and keep the installed npm versio nas is
for all other Node.js versions.
    @phillipj
    phillipj committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    d069397 View commit details
    Browse the repository at this point in the history