Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RDF SVG asset paths in readme #204

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Fix RDF SVG asset paths in readme #204

merged 2 commits into from
Sep 20, 2024

Conversation

DanielYang59
Copy link
Collaborator

Fix the following:

ERROR: 2 dead links found!
[✖] examples/make_assets/element-pair-rdfs-Si16O32.svg → Status: 400
[✖] examples/make_assets/element-pair-rdfs-Na8Nb8O24.svg → Status: 400

@janosh
element_pair_rdfs plots radial distribution functions (RDFs) for el…
b551581 
…ement pairs in a structure (janosh#203)

* improve set_plotly_template auto-complete with Literal type

* add element_pair_rdfs(structure) -> go.Figure in new pymatviz/rdf.py module

* add tests/test_rdf.py

* remove ase.Atoms conversion to avoid new pkg dep

* show element_pair_rdfs examples in readme

* should have used save_and_compress_svg
@DanielYang59 DanielYang59 marked this pull request as ready for review September 20, 2024 03:48
@DanielYang59 DanielYang59 added the docs Improvements or additions to documentation label Sep 20, 2024
@janosh janosh changed the base branch from main to exclude-tests-from-pkg September 20, 2024 14:13
@janosh janosh changed the title Fix RDS svg path Fix RDF SVG asset paths in readme Sep 20, 2024
janosh
janosh approved these changes Sep 20, 2024
View reviewed changes
Copy link
Owner

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks @DanielYang59! 👍

@janosh janosh merged commit e6bba70 into janosh:exclude-tests-from-pkg Sep 20, 2024
21 of 22 checks passed
@DanielYang59 DanielYang59 deleted the fix-svg-rdf branch September 20, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielYang59 @janosh