Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/loaders] html-loader strips </body> when minimizing #144

Closed
blandinw opened this issue Dec 17, 2015 · 4 comments
Closed

[feature/loaders] html-loader strips </body> when minimizing #144

blandinw opened this issue Dec 17, 2015 · 4 comments

Comments

@blandinw
Copy link

If you use the html-loader (that minimizes per default), the regexes to inject tags will break as html-loader uses the removeOptionalTags option from html-minimizer, which removes </body> etc.

One has to be careful and explicitly set html?removeOptionalTags=false!<my-template>.
We should emit a warning if the option is not explicitly set to true.

@jantimon
Copy link
Owner

Probably the same as #135 and #128.

I also opened an issue for the html-loader: webpack-contrib/html-loader#40

@jantimon
Copy link
Owner

Looks like the html-loader might fix this soon: chrisnicola/html-loader@b797acf

@jantimon
Copy link
Owner

jantimon commented Jan 7, 2016

Fixed: 68428b5

@jantimon jantimon closed this as completed Jan 7, 2016
@lock
Copy link

lock bot commented Jun 1, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants