added v5 compilation support and deleted depreciation warnings #1454
Conversation
|
It's looks like there is an error on |
index.js
Outdated
| }); | ||
| }; | ||
|
|
||
| const childCompilationOutputName = webpackMajorVersion === 5 |
There was a problem hiding this comment.
I would invert the logic to support future versions too (and as it is done in other parts of the codebase)
= webpackMajorVersion === 4 ? ... : ...
There was a problem hiding this comment.
That was my first thought too, but we'll lose backward compatibility with v3 and lower, and I'm not 100% that we should support them also? And also this Compilation syntax is different only in webpack v5.
There was a problem hiding this comment.
That was my first thought too, but we'll lose backward compatibility with v3 and lower, and I'm not 100% that we should support them also? And also this
Compilationsyntax is different only in webpack v5.
Compatibility is stated by:
"peerDependencies": {
"webpack": ">=4.0.0 < 6.0.0"
},
html-webpack-plugin/package.json
Line 64 in 115bd8a
There was a problem hiding this comment.
I've one more idea to pick major v5 and higher like:
webpackMajorVersion >= 5 ? ... : ...
What do you think?
There was a problem hiding this comment.
I was more looking to how it was written in file-watcher-api.js.
|
Hi @jantimon can you please check this PR? 🙏 |
|
Released as 4.4.0 - sorry for the delay |
#1408
What I did:
mainTemplate.getAssetPath, andgetPublicPath)I also consider to put this
webpackMajorVersion, as a helper somewhere - is quite repeated few times. Feedback will be needed.