Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR triggers full page reload since version 2.30.1 with webpack 3.x #760

Closed
hendrikeng opened this issue Aug 11, 2017 · 5 comments
Closed

Comments

@hendrikeng
Copy link

Description

Since i upgraded html-webpack-plugin to version 2.30.1 HMR doesn't work anymore.
It always triggers a full page reload (inject js or scss).

The same config does work with html-webpack-plugin@2.28.0, webpack@2.6.1 and webpack-dev-server@2.5.0

Config

 devServer: {
    hot: true,
    inline: true,
    quiet: true,
    contentBase: path.resolve(__dirname, pkg.paths.src.templates),
  watchContentBase: true,
    watchOptions: {
      poll: false, // might be needed for homestead/vagrant setup, review
    },
}
.
.
.
 new HtmlWebpackPlugin({
      template: pkg.paths.src.ejs + pkg.vars.ejsName,
      filename: pkg.paths.src.templates + pkg.vars.templateName,
      inject: true,
      alwaysWriteToDisk: true,
    }),

Environment

webpackalet@0.1.0
├─┬ favicons-webpack-plugin@0.0.7
│ └── webpack@1.15.0
└── webpack@3.5.3

webpackalet@0.1.0
└── html-webpack-plugin@2.30.1
@jantimon
Copy link
Owner

Well I just checked with the changelog:

v2.30.1

Revert part the performance optimization (#723) because of #753.
v2.30.0

Add manual sort
Performance improvements (#723)
v2.29.0

Add support for Webpack 3

And I can't imagine why this would change the HMR behaviour - could you try to debug your environment a little bit and give us an idea where to start?

@hendrikeng
Copy link
Author

I will setup a minimal repo for testing and post it. Thanks a lot.

Sent from my Samsung SM-G920F using FastHub

@hendrikeng
Copy link
Author

hendrikeng commented Aug 11, 2017

@jantimon

this is the minimal repository:

https://github.com/hendrikeng/webpackHMRtest

but it seems like its webpack 3 related ..everything works fine , but as soon as i update webpack to 3.x HMR in js or scss triggers a full reload ...should i move the issue to webpack then? -> webpack/webpack#5505

thanks a lot for your help.

@jantimon
Copy link
Owner

Yes I guess that would be the best way :)

@lock
Copy link

lock bot commented May 31, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants