Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Integration tests suite #120

Closed
gazarenkov opened this issue Jan 8, 2024 · 3 comments
Closed

Integration tests suite #120

gazarenkov opened this issue Jan 8, 2024 · 3 comments
Assignees
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering. jira Issue will be sync'ed to Red Hat JIRA
Milestone

Comments

@gazarenkov
Copy link
Member

There are some problem with current state of integration tests:

  • They all located in one file: backstage-controller_test, which is already huge and difficult to read and continue growing
  • They are not structured and or commented enough, which leads to potential duplicating the cases and, makes it very difficult to understand what is actually tested
  • Testing generic controller features is mixed with testing particular (rhdh) configuration

Proposal:

  • To move integration tests to dedicated package out of controller (indeed, using vars of package scope is quite unlikely)
  • To break it down to shorter, easy to read files woth sufficient contexts and comments
  • To more separate core controller cases from configuration specific, make a configuration profile dedicated folders per-profile (we have only rhdh (or janus-idp) one for the time being but the goal is to make it clear that we test specific configuration and not generic functionality
    For example, the structure may look like (for start):
    /integration
    *_test.go
    /rhdh
    *_test.go
@gazarenkov
Copy link
Member Author

gazarenkov commented Jan 10, 2024

Another thing to consider: how we'd do integration tests on Openshift (e g Route)?

@gazarenkov gazarenkov changed the title Consider restructuring k8s integration tests Integration tests suite Jan 10, 2024
@rm3l rm3l removed this from the M2 - Productization milestone Jan 26, 2024
@gazarenkov gazarenkov added jira Issue will be sync'ed to Red Hat JIRA area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering. labels Jan 31, 2024
@rm3l
Copy link
Member

rm3l commented Feb 26, 2024

Another thing to consider: how we'd do integration tests on Openshift (e g Route)?

Testing on OpenShift should now be possible via the E2E tests introduced in #204 (#90).

@gazarenkov
Copy link
Member Author

gazarenkov commented Feb 28, 2024

Downstream issue https://issues.redhat.com/browse/RHIDP-1461

@gazarenkov gazarenkov modified the milestones: M1 - MVP, M3 Feb 28, 2024
@gazarenkov gazarenkov mentioned this issue Apr 17, 2024
1 task
@gazarenkov gazarenkov self-assigned this Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering. jira Issue will be sync'ed to Red Hat JIRA
Projects
None yet
Development

No branches or pull requests

2 participants