Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Avoid hardcoding the postgres and backstage images in the controller #162

Closed
kim-tsao opened this issue Jan 29, 2024 · 2 comments
Closed

Avoid hardcoding the postgres and backstage images in the controller #162

kim-tsao opened this issue Jan 29, 2024 · 2 comments
Assignees
@gazarenkov
Labels
jira Issue will be sync'ed to Red Hat JIRA kind/bug Categorizes issue or PR as related to a bug.

Comments

@kim-tsao
Copy link
Member

If the env vars are not specified in the SetupWithManager method, the hardcoded defaults are used but these are upstream values. We should allow this to be configurable with the default values from downstream.
@gazarenkov
Copy link
Member

+1 and there are no needs in it since we have our default images configured in non-hardcoded way
https://github.com/janus-idp/operator/blob/main/docs/admin.md

@gazarenkov gazarenkov added kind/bug Categorizes issue or PR as related to a bug. jira Issue will be sync'ed to Red Hat JIRA labels Feb 2, 2024
@gazarenkov gazarenkov self-assigned this Feb 2, 2024
@gazarenkov
Copy link
Member

https://issues.redhat.com/browse/RHIDP-1190

@gazarenkov gazarenkov mentioned this issue Feb 6, 2024
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gazarenkov gazarenkov

Labels
jira Issue will be sync'ed to Red Hat JIRA kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gazarenkov @kim-tsao