Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Raw configuration does not work properly for invalid services #202

Closed
gazarenkov opened this issue Feb 15, 2024 · 1 comment
Closed

Raw configuration does not work properly for invalid services #202

gazarenkov opened this issue Feb 15, 2024 · 1 comment
Labels
jira Issue will be sync'ed to Red Hat JIRA kind/bug Categorizes issue or PR as related to a bug.

Comments

@gazarenkov
Copy link
Member

How to reproduce:

  1. Create configMap (for example name "my-dev-service") for raw configuration with not valid service.xml key (the same would be valid for db-service*)
    For example: spec.port.targetPort=backend:con <--- not valid name

  2. Create Backstage object with

spec:
  rawRuntimeConfig:
    backstageConfig: "my-dev-service"

Expected: Reconciliation failed with Invalid value error, Backstage.status failed, Service object NOT created

In fact: Reconciliation succeeded, Backstage.status DeployOk, Service object NOT created

@gazarenkov gazarenkov added the kind/bug Categorizes issue or PR as related to a bug. label Feb 15, 2024
@github-actions github-actions bot added the jira Issue will be sync'ed to Red Hat JIRA label Feb 15, 2024
@jianrongzhang89
Copy link
Contributor

Add a test case for PR #203.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
jira Issue will be sync'ed to Red Hat JIRA kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants