Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generic_array dependency optional #2

Open
burrbull opened this issue Nov 6, 2018 · 2 comments
Open

Make generic_array dependency optional #2

burrbull opened this issue Nov 6, 2018 · 2 comments

Comments

@burrbull
Copy link
Contributor

burrbull commented Nov 6, 2018

No description provided.

@cbeck88
Copy link

cbeck88 commented Feb 12, 2021

Bumping this issue

In a large project, it can often be the source of strange problems when different crates are using different versions of the same dependency, and when we see that happening in Cargo.lock, we start to investigate.

This crate is the only one that I am aware of that intentionally imports multiple versions of the same library with no way to turn it off.

The preferred way to avoid coordinated upgrade is to use the semver trick, as explained in issues in generic array crate: fizyk20/generic-array#56

and not to have each downstream crate import multiple versions, which creates a mess.

Is there any chance that you will fix this, or take a patch to fix it? you could avoid a breaking change by making the dependencies on generic array optional, as explained in #6

If there's no chance you will take such a patch or offer some alternative, then I'm likely going to fork the crate, this is too annoying downstream

@cbeck88
Copy link

cbeck88 commented Feb 14, 2021

i ended up not forking this, since I realized I don't actually need this trait and the trait is very niche in the first place (AsRef and AsMut are usually enough).
instead i just dropped it as a dependency in my fork of the aligned crate: https://crates.io/crates/aligned-array
i would bring it back if you guys fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants