Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for rem #20

Open
audoh-tickitto opened this issue Feb 23, 2022 · 2 comments
Open

No support for rem #20

audoh-tickitto opened this issue Feb 23, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@audoh-tickitto
Copy link

audoh-tickitto commented Feb 23, 2022

If I use rem as a length unit, I get an "invalid value" error:

ERROR Property: Invalid value for "CSS Backgrounds and Borders Module Level 3" property: 0.75rem [1:1: border-radius]

On investigation, it seems that in https://github.com/jaraco/cssutils/blob/main/cssutils/profiles.py, rem is not supported as a unit:
'length': r'0|{num}(em|ex|px|in|cm|mm|pt|pc)',

Is this something that could be added? I'm not particularly familiar with this module as it's a subdependency so I don't know if it would take more than just adding it to the pattern.

@jaraco jaraco added enhancement New feature or request help wanted Extra attention is needed labels Jun 3, 2022
@jaraco
Copy link
Owner

jaraco commented Jun 3, 2022

I too am not particularly familiar with the implementation. I'd be fine to see support added for it. You may be right - it may be as simple as adding another field to that expression. Can you try adding that and see if that works?

@nsde
Copy link

nsde commented Sep 28, 2022

I also think that this feature is really important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants