Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Replace use of pkg_resources with importlib.metadata #22

Closed
kloczek opened this issue Apr 22, 2022 · 3 comments
Closed

RFE: Replace use of pkg_resources with importlib.metadata #22

kloczek opened this issue Apr 22, 2022 · 3 comments

Comments

@kloczek
Copy link

kloczek commented Apr 22, 2022

See discussions:
astropy/astropy#11091
pypa/pip#7413

[tkloczko@devel-g2v SRPMS]$ rpm -ql python-cssutils | grep py$ | xargs grep pkg_resources
/usr/lib/python3.8/site-packages/cssutils/tests/basetest.py:        from pkg_resources import resource_filename
@kloczek
Copy link
Author

kloczek commented Jun 3, 2022

Q about about cssutils/tests/
IS that directory is not by mistake installed? Looks like it is test suite and probably whole install exclude list 🤔

@jaraco
Copy link
Owner

jaraco commented Jun 3, 2022

I’m not too bothered if tests are installed. If you would like to file a feature request, this project could consider it.

@kloczek
Copy link
Author

kloczek commented Jun 3, 2022

If those files are only private test suite ad have no any other use case those files should be not installed.

So Q is: do you know anything that cssutils/tests/ is currently used by any other modules? If answer is "no" than those files should not be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants