Server environment variables are reaching the client

[krazyjakee]

Bug, Feature, or Question?

bug

Current Behavior

According the the razzle readme, having a envConfig file that serves the client and server differently should work but it doesn't.

Here @jaredpalmer suggested they would only be available if they were written into isomorphic code: jaredpalmer/razzle#528 (comment)

Desired Behavior

server-side variables should never reach the client.

Suggested Solutions

Perhaps either fix the isomorphic environment variables like razzle, or afterjs should provide it's own env-vars serialise function to separate client from server?

Additional Information

It could be related to this issue on the lack of tree-shaking as it potentially means those variables are reaching isomorphic javascript.

Here is a minimal example: https://github.com/krazyjakee/Afterjs-Sandbox/blob/environment-variables/src/Document.js#L42

---

• After.js Version: 1.3.1
• Razzle Version: 2.4.0
• React Version: 16.5.1
• OS: OSX High Sierra
• Node Version: 10.10.0
• Package Manager and Version: npm 6.4.1

[krazyjakee]

Tree-shaking in razzle v3 solved this.