Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-docs: return type of setValue in docs did not match the function typing #3871

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

DavideFrancescon
Copy link
Contributor

Function return
Docs before changes: setValues: (fields: React.SetStateAction<{ [field: string]: any }>, shouldValidate?: boolean) => void
Closes: #3846

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023

⚠️ No Changeset found

Latest commit: 405578c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 3:19pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 405578c:

Sandbox Source
Formik TypeScript Playground (forked) Configuration
Formik Codesandbox Template (forked) Issue #3846
Formik Codesandbox Template Issue #3846
withFormik Codesandbox Template Issue #3846

Copy link
Collaborator

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@quantizor quantizor added the automerge automerge label for kodiak label Sep 2, 2023
@quantizor quantizor added automerge automerge label for kodiak and removed automerge automerge label for kodiak labels Sep 11, 2023
@quantizor
Copy link
Collaborator

@DavideFrancescon for whatever reason your branch seems to be having issues staying up to date, could you merge main for me to get this good for merging?

@DavideFrancescon
Copy link
Contributor Author

@DavideFrancescon for whatever reason your branch seems to be having issues staying up to date, could you merge main for me to get this good for merging?

It SHOULD be okay now, hopefully, let me know if it works!
Thanks for your time

@DavideFrancescon
Copy link
Contributor Author

@probablyup I guess it does not work :')

I don't think I can do much about this as mine was only a small change and surely didn't cause this much of a performance issue.

@quantizor
Copy link
Collaborator

@probablyup I guess it does not work :')

I don't think I can do much about this as mine was only a small change and surely didn't cause this much of a performance issue.

I think it's just some transient weirdness, rerunning the job.

@DavideFrancescon
Copy link
Contributor Author

@probablyup I guess it does not work :')
I don't think I can do much about this as mine was only a small change and surely didn't cause this much of a performance issue.

I think it's just some transient weirdness, rerunning the job.

What if I try adding a new commit with like a new-line somewhere just to reset the algorithm?

@quantizor
Copy link
Collaborator

Going to fix the check to not run when it's unnecessary → #3880

@quantizor quantizor merged commit ce305f5 into jaredpalmer:main Sep 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge label for kodiak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling setValues twice uses stale data
2 participants