v2: hmr isn't working if PORT not set

[gregmartyn]

This is for the "next" branch.

If the PORT environment variable isn't specified, webpackHotDevClient.js is using window.location.port for the SockJS connection when it should be window.location.port + 1.

Additionally, if the page is served on port 80, then window.location.port = ''. I'm only hitting that because I have razzle.config.js removing PORT from the DefinePlugin array as a stopgap until #528 moves forward. Regardless, it's a case that can be handled pretty easily.

I've created #581 to address both of those issues.

[stale]

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

[gregmartyn]

@jaredpalmer this is still an issue for me, fixed by the #581 pr.

[stale]

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

[gregmartyn]

@jaredpalmer is there anything left to do for #581 to be accepted? Seems like a simple fix to me. window.location.port returns "" if port is 80, and that wasn't being handled by the existing code.

[stale]

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

[gregmartyn]

still not stale

[fivethreeo]

Fixed. Closing