From 2dd4396fb86b1b9bdb122595e388bfacd83cf34f Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Sat, 11 Apr 2020 23:57:07 -0400 Subject: [PATCH] (clean): remove redundant tsconfig strict opts in templates (#673) - noImplicitAny, noImplicitThis, alwaysStrict, strictNullChecks, strictFunctionTypes, and strictPropertyInitialization are already enabled by strict, no need to configure them twice - beginners could also be confused by redundant options (like I was at one point) - and including them may have also unintentionally encouraged folks to turn them off --- templates/basic/tsconfig.json | 6 ------ templates/react-with-storybook/tsconfig.json | 6 ------ templates/react/tsconfig.json | 6 ------ 3 files changed, 18 deletions(-) diff --git a/templates/basic/tsconfig.json b/templates/basic/tsconfig.json index a502b91b6..1e79b510b 100644 --- a/templates/basic/tsconfig.json +++ b/templates/basic/tsconfig.json @@ -8,12 +8,6 @@ "sourceMap": true, "rootDir": "./src", "strict": true, - "noImplicitAny": true, - "strictNullChecks": true, - "strictFunctionTypes": true, - "strictPropertyInitialization": true, - "noImplicitThis": true, - "alwaysStrict": true, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true, diff --git a/templates/react-with-storybook/tsconfig.json b/templates/react-with-storybook/tsconfig.json index 06ffbb74c..71606db2f 100644 --- a/templates/react-with-storybook/tsconfig.json +++ b/templates/react-with-storybook/tsconfig.json @@ -8,12 +8,6 @@ "sourceMap": true, "rootDir": "./src", "strict": true, - "noImplicitAny": true, - "strictNullChecks": true, - "strictFunctionTypes": true, - "strictPropertyInitialization": true, - "noImplicitThis": true, - "alwaysStrict": true, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true, diff --git a/templates/react/tsconfig.json b/templates/react/tsconfig.json index a502b91b6..1e79b510b 100644 --- a/templates/react/tsconfig.json +++ b/templates/react/tsconfig.json @@ -8,12 +8,6 @@ "sourceMap": true, "rootDir": "./src", "strict": true, - "noImplicitAny": true, - "strictNullChecks": true, - "strictFunctionTypes": true, - "strictPropertyInitialization": true, - "noImplicitThis": true, - "alwaysStrict": true, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true,