Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript from 3 to 4 #1147

Open
johann1301s opened this issue Jul 22, 2022 · 6 comments
Open

Update typescript from 3 to 4 #1147

johann1301s opened this issue Jul 22, 2022 · 6 comments

Comments

@johann1301s
Copy link

TSDX uses typescript version 3.

Many new features are available in version 4. Please update to the latest version.

@tim-phillips
Copy link

tim-phillips commented Jul 25, 2022

The latest code in this repo uses typescript v4, but the latest published version of TSDX is still referencing v3, however the build step in the published version is using rollup-plugin-typescript2@0.27.3, which is using typescript@4.0.3.

@johann1301s
Copy link
Author

johann1301s commented Jul 27, 2022

If you for example use Template Literal Types, for instance;

type World = "world";
 
type Greeting = `hello ${World}`;

Compilation fails since it is a TS 4.1 feature.

@OrkhanAlikhanov
Copy link

@tim-phillips That's not correct. At least with yarn. Rollup gets to use ts 3.9. I have a script that removes that typescript from local node_modules of tsdx. That makes it use ts 4 installed. Something like this:

"prebuild": "rm -rf node_modules/tsdx/node_modules/typescript"

@karlhorky
Copy link
Contributor

There are a number of other issues in this repository about the super-old TypeScript 3.9.9 inside tsdx@0.14.1 causing problems for people, where this is documented:

@TheMikeyRoss
Copy link

I think this repo is abandoned by @jaredpalmer

@Vovan-VE
Copy link

Using a fork weiran-zsd/dts-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants