Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a way to run test in non-interactive mode without defining CI #408

Closed
etienne-dldc opened this issue Jan 1, 2020 · 2 comments · Fixed by #421
Closed

Expose a way to run test in non-interactive mode without defining CI #408

etienne-dldc opened this issue Jan 1, 2020 · 2 comments · Fixed by #421

Comments

@etienne-dldc
Copy link
Contributor

Current Behavior

  • yarn test start jest in interactive mode
  • Setting CI=true start jest in non-interactive mode but without colors because most tools only check wether or not the CI environment variables exist an not it's value:
    https://github.com/watson/ci-info/blob/master/index.js#L53
    Because of this you loose some functionalities, like colors when using tools like np or lerna.

Desired Behavior

Being able to run tsdx test in non-interactive way without setting the CI variable.

Suggested Solution

Using a different environment variable name to disable "auto watch mode":

TSDX_AUTO_WATCH=false tsdx test

Who does this impact? Who is this for?

This impact everyone who was using tsdx test in non-interactive mode outside of a CI.
It would make the migration from 0.11 to 0.12 easier.

@swyxio
Copy link
Collaborator

swyxio commented Jan 2, 2020

ohh.. good point 😬

@jaredpalmer we may have to revert this and just use a watch flag.

@jaredpalmer
Copy link
Owner

Okay let’s revert then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants