Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using office-ui-fabric-react as a dependency in my library results in an error #461

Closed
Wezea opened this issue Jan 27, 2020 · 3 comments
Closed
Labels
kind: support Asking for support with something or a specific use case problem: stale Issue has not been responded to in some time scope: upstream Issue in upstream dependency

Comments

@Wezea
Copy link

Wezea commented Jan 27, 2020

I don't know if this a an issue of the related dependency office-ui-fabric-react or the way tsdx is dealing with it.

I've submited an issue here as well.

Current Behavior

If using office-ui-fabric-react as a dependency the example projects crashes with:

TypeError: can't redefine non-configurable property "MAX_COLOR_SATURATION"

Expected behavior

My small example should render FabricThing without an error.

Suggested solution(s)

I don't understand the whole setup good enough to answer this question.

Your environment

https://github.com/Wezea/fabriclib

Software Version(s)
TSDX 0.12.3
TypeScript 3.7.5
Browser Firefox 72.0.2
npm/Yarn 6.13.4
Node 12.14.1
Operating System Windows 10
@Wezea Wezea changed the title Using office-ui-fabric-react as a dependeny in my library results in an error Using office-ui-fabric-react as a dependency in my library results in an error Jan 27, 2020
@swyxio
Copy link
Collaborator

swyxio commented Jan 28, 2020

please provide more information on how this is specifically a bug in tsdx, we will not have the capacity to debug for you.

@agilgur5
Copy link
Collaborator

agilgur5 commented Feb 1, 2020

So this is a type of runtime crash and it's coming from the import of OUFR:
https://github.com/Wezea/fabriclib/blob/7de0c4e4c6e0a6ecb8b55f4f43fb930e7c10f150/src/index.tsx#L3

It's occurring with Parcel from the templates, not from tsdx build. It's definitely coming from OUFR code, though I suppose it's possible something is being transpiled in a way different from expected EDIT: external dependencies aren't generally compiled in tsdx build -- they're left as externals (unless you've configured it differently).

Will echo the "capacity to debug" part for anything further.

@agilgur5 agilgur5 added the problem: stale Issue has not been responded to in some time label Mar 9, 2020
@agilgur5 agilgur5 closed this as completed Mar 9, 2020
@agilgur5 agilgur5 added the kind: support Asking for support with something or a specific use case label Mar 9, 2020
@agilgur5
Copy link
Collaborator

agilgur5 commented Apr 14, 2020

@waqas19921 please read the previous comments above:

please provide more information on how this is specifically a bug in tsdx, we will not have the capacity to debug for you.

It's occurring with Parcel from the templates, not from tsdx build. It's definitely coming from OUFR code

Per previous comments, this is not a support forum and it's not clear that that's a bug in TSDX; it's coming from Parcel parsing OUFR code, not from tsdx build. tsdx build does not generally touch external dependencies.

Going to lock this thread if this repeats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: support Asking for support with something or a specific use case problem: stale Issue has not been responded to in some time scope: upstream Issue in upstream dependency
Projects
None yet
Development

No branches or pull requests

3 participants