Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs/fix): fix ToC changes / bugs introduced in #307 #397

Merged
merged 1 commit into from
Dec 28, 2019

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Dec 27, 2019

  • __DEV__ link stopped working

  • Contributors link didn't work

  • backtick formatting was removed

  • this was all re-generated by using npx doctoc README.md

    • doctoc is specified to be used in the ToC comments

Noted in #307 (comment) and #307 (comment)

- __DEV__ link stopped working
- Contributors link didn't work

- backtick formatting was removed

- this was all re-generated by using `npx doctoc README.md`
  - doctoc is specified to be used in the ToC comments
@agilgur5
Copy link
Collaborator Author

No clue why windows tests seemed to randomly fail on this PR, especially when I made like 5 PRs in a row, and this is the only one that has failures (in code that wasn't even changed)

@swyxio
Copy link
Collaborator

swyxio commented Dec 28, 2019

not sure why this happens either. here's the failing test
image

so its some sort of filesystem permission issue that is also a race condition? need to investigate and do some trial and error. probably an easy fix.

@swyxio swyxio merged commit 387f3c2 into jaredpalmer:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants