mojohaus#299: allowAnyUpdates should be ignored if any of: allowMajor…

…Updates, allowMinorUpdates, allowIncrementalUpdates is set to false
andrzejj0 · Apr 9, 2023 · c111aad · c111aad
1 parent 426fac7
commit c111aad
Show file tree

Hide file tree

Showing 3 changed files with 154 additions and 117 deletions.
diff --git a/...s-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayDependencyUpdatesMojo.java b/...s-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayDependencyUpdatesMojo.java
@@ -246,11 +246,12 @@ public class DisplayDependencyUpdatesMojo extends AbstractVersionsDisplayMojo {
     private boolean allowIncrementalUpdates = true;
 
     /**
-     * Whether to allow any version change to be allowed. This keeps
-     * compatibility with previous versions of the plugin.
-     * If you set this to false you can control changes in version
-     * number by {@link #allowMajorUpdates}, {@link #allowMinorUpdates} or
-     * {@link #allowIncrementalUpdates}.
+     * <p>Whether to allow any version change to be allowed. This keeps
+     * compatibility with previous versions of the plugin.</p>
+     *
+     * <p><b>Note: Setting any of the: {@linkplain #allowMajorUpdates},
+     * {@linkplain #allowMinorUpdates}, {@linkplain #allowIncrementalUpdates}
+     * to {@code false} implies this to be {@code false} as well.</b></p>
      *
      * @since 2.5
      * @deprecated This will be removed with version 3.0.0
@@ -506,7 +507,7 @@ static void validateGAVList(List<String> gavList, int numSections, String argume
     }
 
     private Optional<Segment> calculateUpdateScope() {
-        return allowAnyUpdates
+        return allowAnyUpdates && allowMajorUpdates && allowMinorUpdates && allowIncrementalUpdates
                 ? empty()
                 : of(SegmentUtils.determineUnchangedSegment(
                                 allowMajorUpdates, allowMinorUpdates, allowIncrementalUpdates, getLog())